bugfix: fix incorrect getAnnotation about class and method #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2617 +/- ##
=============================================
- Coverage 50.92% 50.77% -0.15%
+ Complexity 2817 2816 -1
=============================================
Files 558 558
Lines 17941 17944 +3
Branches 2129 2101 -28
=============================================
- Hits 9136 9111 -25
- Misses 7938 7939 +1
- Partials 867 894 +27 |
|
add test case |
ok |
helloworlde
reviewed
Apr 27, 2020
spring/src/main/java/io/seata/spring/annotation/GlobalTransactionalInterceptor.java
Show resolved
Hide resolved
funky-eyes
changed the title
|
@zjinlei PTAL |
jsbxyyx
reviewed
Apr 27, 2020
| @@ -37,6 +36,8 @@ | |||
| private static Class<?> targetClass = null; | |||
| private static GlobalTransactional transactional = null; | |||
|
|
|||
| private static final GlobalTransactionalInterceptor globalTransactionalInterceptor=new GlobalTransactionalInterceptor(null); | |||
There was a problem hiding this comment.
The global variable declare in testGetAnnotation method?
There was a problem hiding this comment.
The global variable declare in testGetAnnotation method?
PTAL @jsbxyyx
zjinlei
changed the title
zjinlei
changed the title
zjinlei
changed the title
|
toString，hashcode these methods also take distributed transactions? |
|
测试了一下，注解加在类上、方法上、类及方法上混用、嵌套调用都没问题 |
PTAL @slievrly |
|
add hashCode and equals ... test case? |
Codecov Report
@@ Coverage Diff @@
## develop #2617 +/- ##
=============================================
+ Coverage 50.95% 51.05% +0.10%
- Complexity 2830 2836 +6
=============================================
Files 563 563
Lines 18043 18047 +4
Branches 2136 2138 +2
=============================================
+ Hits 9193 9214 +21
+ Misses 7980 7951 -29
- Partials 870 882 +12
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
bug fix for getAnnotation
1.类上有注解,方法无 可正常运行
2.方法有注解,类上无 可正常运行
3.类上方法上都有,优先读取方法上注解 可正常运行
4.基类方法调用时,排除基类调用 可正常运行
5.类重写基类方法,比如toString后,重写的方法属于本类方法,因此会开启全局事务.
Ⅱ. Does this pull request fix one issue?
fix #2562
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews