-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix could not create folder in zookeeper #2618
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2618 +/- ##
=============================================
- Coverage 51.20% 51.19% -0.02%
+ Complexity 2810 2808 -2
=============================================
Files 554 554
Lines 17774 17774
Branches 2100 2100
=============================================
- Hits 9102 9100 -2
Misses 7812 7812
- Partials 860 862 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
建议把标题改为bugfix:修复了什么的英文. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very detailed considerations.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Locally build a cluster to verify pr, is ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
seata-server使用zookeeper作为注册中心时,zookeeper要求设置密码才可以建立目录和写数据。
Ⅱ. Does this pull request fix one issue?
原有实现是先建目录,再设置密码进行写数据;但是当zookeeper根目录都要求有密码访问时,原实现会出错。需要改为先设置密码,再创建目录和写数据。
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews