Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix could not create folder in zookeeper #2618

Merged
merged 2 commits into from
Apr 27, 2020

Conversation

anic
Copy link
Contributor

@anic anic commented Apr 27, 2020

Ⅰ. Describe what this PR did

seata-server使用zookeeper作为注册中心时,zookeeper要求设置密码才可以建立目录和写数据。

Ⅱ. Does this pull request fix one issue?

原有实现是先建目录,再设置密码进行写数据;但是当zookeeper根目录都要求有密码访问时,原实现会出错。需要改为先设置密码,再创建目录和写数据。

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Apr 27, 2020

Codecov Report

Merging #2618 into develop will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2618      +/-   ##
=============================================
- Coverage      51.20%   51.19%   -0.02%     
+ Complexity      2810     2808       -2     
=============================================
  Files            554      554              
  Lines          17774    17774              
  Branches        2100     2100              
=============================================
- Hits            9102     9100       -2     
  Misses          7812     7812              
- Partials         860      862       +2     
Impacted Files Coverage Δ Complexity Δ
...very/registry/zk/ZookeeperRegisterServiceImpl.java 60.93% <100.00%> (ø) 25.00 <0.00> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 54.63% <0.00%> (-0.52%) 28.00% <0.00%> (-1.00%)
...in/java/io/seata/server/session/GlobalSession.java 83.71% <0.00%> (-0.46%) 71.00% <0.00%> (-1.00%)

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes
Copy link
Contributor

建议把标题改为bugfix:修复了什么的英文.

@l81893521 l81893521 added the first-time contributor first-time contributor label Apr 27, 2020
@l81893521 l81893521 changed the title 将zookeeper设置密码的语句放在创建目录前 bugfix: fix could not create folder in zookeeper Apr 27, 2020
Copy link
Contributor

@objcoding objcoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very detailed considerations.
LGTM.

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@objcoding objcoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally build a cluster to verify pr, is ok.

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 merged commit b6c5e73 into apache:develop Apr 27, 2020
@anic anic deleted the seata-anic2 branch April 29, 2020 08:16
xiaowan pushed a commit to xiaowan/seata that referenced this pull request Apr 30, 2020
@wangliang181230 wangliang181230 added this to the 1.3.0 milestone Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants