optimize: polish testing code, replace with Mockito.verify
#2625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 27, 2020 22:26
The purposes of those test cases is just to assert if the target methods whether are invoked or not. Using `Mockito.doAnswer` with instrumental variables is too complex and makes code hard to read. Replacing with `Mockito.verify` can make the code more clean and readable.
Codecov Report
@@ Coverage Diff @@
## develop #2625 +/- ##
=============================================
+ Coverage 50.75% 50.87% +0.12%
+ Complexity 2814 2812 -2
=============================================
Files 557 557
Lines 17904 17905 +1
Branches 2094 2124 +30
=============================================
+ Hits 9087 9109 +22
- Misses 7929 7930 +1
+ Partials 888 866 -22 |
l81893521
changed the title
Mockito.verifyMockito.verify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
The purposes of those test cases is just to assert if the target methods whether are invoked or not.
Using
Mockito.doAnswerwith instrumental variables is too complex and makes code hard to read.Replacing with
Mockito.verifycan make the code more clean and readable.Ⅱ. Does this pull request fix one issue?
No
Ⅲ. Why don't you add test cases (unit test/integration test)?
polish testing code
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews