Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize get table meta #2649

Merged
merged 4 commits into from
May 3, 2020

Conversation

l81893521
Copy link
Contributor

Ⅰ. Describe what this PR did

optimize get table meta

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@l81893521 l81893521 requested a review from zjinlei May 2, 2020 06:52
@codecov-io
Copy link

codecov-io commented May 2, 2020

Codecov Report

Merging #2649 into develop will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2649      +/-   ##
=============================================
- Coverage      51.20%   51.20%   -0.01%     
+ Complexity      2821     2820       -1     
=============================================
  Files            556      556              
  Lines          17833    17828       -5     
  Branches        2110     2109       -1     
=============================================
- Hits            9132     9129       -3     
+ Misses          7835     7833       -2     
  Partials         866      866              
Impacted Files Coverage Δ Complexity Δ
...ource/sql/struct/cache/AbstractTableMetaCache.java 85.71% <100.00%> (+3.89%) 8.00 <0.00> (-1.00) ⬆️

@zjinlei zjinlei added this to the 1.3.0 milestone May 2, 2020
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei
Copy link
Contributor

zjinlei commented May 2, 2020

Title can be clearer, such as removing redundant code

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 3cc218d into apache:develop May 3, 2020
@l81893521 l81893521 deleted the optimize_get_table_meta branch May 16, 2020 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants