-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: consul supports custom port #2652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@a364176773 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## develop #2652 +/- ##
=============================================
+ Coverage 51.06% 51.07% +0.01%
- Complexity 2811 2813 +2
=============================================
Files 557 557
Lines 17823 17823
Branches 2105 2105
=============================================
+ Hits 9101 9103 +2
Misses 7857 7857
+ Partials 865 863 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@helloworlde please update ConsulRegistryServiceImpl together |
Ⅰ. Describe what this PR did
Fixed issue #2599 which can't get correct consul config center address
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews