Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: consul supports custom port #2652

Merged
merged 3 commits into from
May 5, 2020
Merged

optimize: consul supports custom port #2652

merged 3 commits into from
May 5, 2020

Conversation

helloworlde
Copy link
Contributor

Ⅰ. Describe what this PR did

Fixed issue #2599 which can't get correct consul config center address

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@zjinlei zjinlei added this to the 1.3.0 milestone May 4, 2020
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly
Copy link
Member

slievrly commented May 5, 2020

@a364176773

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented May 5, 2020

Codecov Report

Merging #2652 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2652      +/-   ##
=============================================
+ Coverage      51.06%   51.07%   +0.01%     
- Complexity      2811     2813       +2     
=============================================
  Files            557      557              
  Lines          17823    17823              
  Branches        2105     2105              
=============================================
+ Hits            9101     9103       +2     
  Misses          7857     7857              
+ Partials         865      863       -2     
Impacted Files Coverage Δ Complexity Δ
...in/java/io/seata/server/session/GlobalSession.java 84.16% <0.00%> (+0.45%) 72.00% <0.00%> (+1.00%)
...o/seata/server/coordinator/DefaultCoordinator.java 55.15% <0.00%> (+0.51%) 29.00% <0.00%> (+1.00%)

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei
Copy link
Contributor

zjinlei commented May 5, 2020

@helloworlde please update ConsulRegistryServiceImpl together

@zjinlei zjinlei added the status: waiting-for-feedback Waiting for feedback label May 5, 2020
@zjinlei zjinlei changed the title bugfix: fixed issue of can't get correct consul config center address optimize: consul supports custom port May 5, 2020
@zjinlei zjinlei removed the status: waiting-for-feedback Waiting for feedback label May 5, 2020
@zjinlei zjinlei merged commit 9c9212d into apache:develop May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants