-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature : Data sources supporting different permissions of Oracle users #2658
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2658 +/- ##
=============================================
- Coverage 51.01% 51.01% -0.01%
- Complexity 2814 2815 +1
=============================================
Files 557 557
Lines 17843 17847 +4
Branches 2108 2110 +2
=============================================
+ Hits 9103 9105 +2
- Misses 7875 7876 +1
- Partials 865 866 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
#2605
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews