Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature : Data sources supporting different permissions of Oracle users #2658

Merged
merged 7 commits into from
May 10, 2020

Conversation

ph3636
Copy link
Contributor

@ph3636 ph3636 commented May 6, 2020

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

#2605

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@zjinlei zjinlei added this to the 1.3.0 milestone May 6, 2020
@codecov-io
Copy link

Codecov Report

Merging #2658 into develop will decrease coverage by 0.00%.
The diff coverage is 25.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2658      +/-   ##
=============================================
- Coverage      51.01%   51.01%   -0.01%     
- Complexity      2814     2815       +1     
=============================================
  Files            557      557              
  Lines          17843    17847       +4     
  Branches        2108     2110       +2     
=============================================
+ Hits            9103     9105       +2     
- Misses          7875     7876       +1     
- Partials         865      866       +1     
Impacted Files Coverage Δ Complexity Δ
...n/java/io/seata/rm/datasource/DataSourceProxy.java 36.84% <25.00%> (-0.90%) 11.00 <0.00> (+1.00) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 55.15% <0.00%> (+0.51%) 29.00% <0.00%> (ø%)

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 1045c7f into apache:develop May 10, 2020
@ph3636 ph3636 deleted the Oracle_UserName branch May 11, 2020 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants