bugfix: fix mysql insert use select last insert id is undo_log id value #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2659 +/- ##
=============================================
+ Coverage 51.01% 51.02% +0.01%
- Complexity 2812 2814 +2
=============================================
Files 557 557
Lines 17843 17843
Branches 2108 2108
=============================================
+ Hits 9102 9104 +2
Misses 7875 7875
+ Partials 866 864 -2
|
|
is mysql the only one that need to handle ? |
|
@a364176773 oracle, postgresql use sequence. |
slievrly
reviewed
May 7, 2020
zjinlei
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
mysql business insert use select last insert id is undo_log id's value.
Ⅱ. Does this pull request fix one issue?
fixes: #2655
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews