bugfix: fix data source initialize more times #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l81893521
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #2670 +/- ##
=============================================
+ Coverage 50.65% 50.91% +0.25%
- Complexity 2812 2814 +2
=============================================
Files 558 558
Lines 17914 17936 +22
Branches 2088 2126 +38
=============================================
+ Hits 9075 9132 +57
+ Misses 7947 7934 -13
+ Partials 892 870 -22
|
jsbxyyx
reviewed
May 9, 2020
core/src/main/java/io/seata/core/store/db/DataSourceGenerator.java
Outdated
Show resolved
Hide resolved
zjinlei
reviewed
May 9, 2020
core/src/main/java/io/seata/core/store/db/AbstractDataSourceGenerator.java
Outdated
Show resolved
Hide resolved
|
@l81893521 Whether to need to adjust the connection pool of the default number of connections? |
ok, DEFAULT_DB_MAX_CONN already change to 20 |
zjinlei
reviewed
May 10, 2020
|
|
||
| @Override | ||
| public DataSource provide() { | ||
| return getDataSource(); |
There was a problem hiding this comment.
common method, move to abstract class.
slievrly
approved these changes
May 11, 2020
| private final String datasourceType = "dbcp"; | ||
|
|
||
| @Test | ||
| public void testDbcpDataSourceProvider() { |
There was a problem hiding this comment.
You can put the test case in the abstract class
|
Pay attention to the package order |
jsbxyyx
reviewed
May 12, 2020
| */ | ||
| public class AbstractDataSourceProviderTest { | ||
|
|
||
| private final String dbcpDatasourceType = "dbcp"; |
There was a problem hiding this comment.
merge dataSourceType to array. for each test dataSource not null? simplify test case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
fix data source initialize more than one time cause the data source instance is not a single instance.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews