Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature : support least active load balance #2676

Merged
merged 28 commits into from
Oct 20, 2020
Merged

feature : support least active load balance #2676

merged 28 commits into from
Oct 20, 2020

Conversation

ph3636
Copy link
Contributor

@ph3636 ph3636 commented May 11, 2020 •
edited

Ⅰ. Describe what this PR did

support LeastActiveLoadBalance

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented May 11, 2020 •
edited

Codecov Report

Merging #2676 into develop will decrease coverage by 0.14%.
The diff coverage is 50.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2676      +/-   ##
=============================================
- Coverage      50.92%   50.77%   -0.15%     
- Complexity      2817     2823       +6     
=============================================
  Files            558      560       +2     
  Lines          17941    17972      +31     
  Branches        2129     2103      -26     
=============================================
- Hits            9136     9126      -10     
- Misses          7938     7955      +17     
- Partials         867      891      +24
Impacted Files Coverage Δ Complexity Δ
...n/src/main/java/io/seata/common/rpc/RpcStatus.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../discovery/loadbalance/LeastActiveLoadBalance.java 100.00% <100.00%> (ø) 7.00 <7.00> (?)
...obuf/convertor/BranchRegisterRequestConvertor.java 90.47% <0.00%> (-9.53%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalBeginResponseConvertor.java 92.59% <0.00%> (-7.41%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalCommitRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalStatusRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...obuf/convertor/GlobalRollbackRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...protobuf/convertor/RegisterTMRequestConvertor.java 94.73% <0.00%> (-5.27%) 3.00% <0.00%> (ø%)
...protobuf/convertor/RegisterRMRequestConvertor.java 90.47% <0.00%> (-4.77%) 3.00% <0.00%> (ø%)
...otobuf/convertor/BranchReportRequestConvertor.java 95.45% <0.00%> (-4.55%) 3.00% <0.00%> (ø%)
... and 18 more

@zjinlei zjinlei added this to the 1.3.0 milestone May 12, 2020
@xingfudeshi xingfudeshi self-requested a review May 18, 2020 01:49
@l81893521 l81893521 added module/common common module module/discovery discovery module labels May 18, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020 •
edited

Codecov Report

Merging #2676 into develop will increase coverage by 0.04%.
The diff coverage is 65.38%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2676      +/-   ##
=============================================
+ Coverage      50.45%   50.49%   +0.04%     
- Complexity      3108     3124      +16     
=============================================
  Files            593      596       +3     
  Lines          19571    19622      +51     
  Branches        2427     2431       +4     
=============================================
+ Hits            9874     9908      +34     
- Misses          8702     8719      +17     
  Partials         995      995
Impacted Files Coverage Δ Complexity Δ
...io/seata/core/rpc/netty/AbstractNettyRemoting.java 13.42% <6.66%> (-0.66%) 5.00 <0.00> (ø)
...ain/java/io/seata/core/rpc/hook/StatusRpcHook.java 20.00% <20.00%> (ø) 1.00 <1.00> (?)
...n/src/main/java/io/seata/common/rpc/RpcStatus.java 100.00% <100.00%> (ø) 8.00 <8.00> (?)
.../discovery/loadbalance/LeastActiveLoadBalance.java 100.00% <100.00%> (ø) 7.00 <7.00> (?)

@ph3636 ph3636 changed the title feature : support LeastActiveLoadBalance [WIP]feature : support LeastActiveLoadBalance May 25, 2020
@slievrly slievrly removed this from the 1.3.0 milestone Jun 29, 2020
@ph3636 ph3636 changed the title [WIP]feature : support LeastActiveLoadBalance feature : support LeastActiveLoadBalance Jul 21, 2020
@l81893521 l81893521 added this to the 1.4.0 milestone Aug 5, 2020
ph3636 and others added 3 commits August 5, 2020 19:35
Merge branch 'develop' into LeastActiveLoadBalance
149ea5d 
# Conflicts:
#	discovery/seata-discovery-core/src/main/resources/META-INF/services/io.seata.discovery.loadbalance.LoadBalance
#	discovery/seata-discovery-core/src/test/java/io/seata/discovery/loadbalance/LoadBalanceTest.java
feature: support LeastActiveLoadBalance
d078ced
@l81893521
Merge branch 'develop' into LeastActiveLoadBalance
5944cce
l81893521
l81893521 approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xingfudeshi
xingfudeshi approved these changes Aug 16, 2020
View reviewed changes
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Oct 20, 2020 •
edited

Codecov Report

Merging #2676 into develop will increase coverage by 0.05%.
The diff coverage is 65.38%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2676      +/-   ##
=============================================
+ Coverage      50.89%   50.94%   +0.05%     
- Complexity      3205     3222      +17     
=============================================
  Files            602      605       +3     
  Lines          19836    19887      +51     
  Branches        2477     2481       +4     
=============================================
+ Hits           10096    10132      +36     
- Misses          8726     8742      +16     
+ Partials        1014     1013       -1
Impacted Files Coverage Δ Complexity Δ
...io/seata/core/rpc/netty/AbstractNettyRemoting.java 13.42% <6.66%> (-0.66%) 5.00 <0.00> (ø)
...ain/java/io/seata/core/rpc/hook/StatusRpcHook.java 20.00% <20.00%> (ø) 1.00 <1.00> (?)
...n/src/main/java/io/seata/common/rpc/RpcStatus.java 100.00% <100.00%> (ø) 8.00 <8.00> (?)
.../discovery/loadbalance/LeastActiveLoadBalance.java 100.00% <100.00%> (ø) 7.00 <7.00> (?)
...torage/file/store/FileTransactionStoreManager.java 57.41% <0.00%> (+0.64%) 29.00% <0.00%> (+1.00%)

@l81893521 l81893521 changed the title feature : support LeastActiveLoadBalance feature : support least active load balance Oct 20, 2020
@l81893521 l81893521 merged commit 7ea7399 into apache:develop Oct 20, 2020
@ph3636 ph3636 deleted the LeastActiveLoadBalance branch November 2, 2020 12:50
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
@ph3636 @hicf
feature : support least active load balance (apache#2676)
b30a362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slievrly slievrly slievrly left review comments

@l81893521 l81893521 l81893521 approved these changes

@xingfudeshi xingfudeshi xingfudeshi approved these changes

Assignees
No one assigned
Labels
module/common common module module/discovery discovery module
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@ph3636 @codecov-io @codecov-commenter @l81893521 @slievrly @xingfudeshi @zjinlei @wangliang181230