Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize : Change GlobalTransactionalInterceptor to singleton #2680

Merged
merged 2 commits into from
May 12, 2020

Conversation

ph3636
Copy link
Contributor

@ph3636 ph3636 commented May 12, 2020

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei requested a review from slievrly May 12, 2020 03:18
@zjinlei zjinlei changed the title optimize : Change GlobalTransactionalInterceptor to a single example optimize : Change GlobalTransactionalInterceptor to a singleton May 12, 2020
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei changed the title optimize : Change GlobalTransactionalInterceptor to a singleton optimize : Change GlobalTransactionalInterceptor to singleton May 12, 2020
@zjinlei zjinlei merged commit e0918f9 into apache:develop May 12, 2020
@zjinlei zjinlei added this to the 1.3.0 milestone May 12, 2020
@ph3636 ph3636 deleted the GlobalTransactionalInterceptor branch May 12, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants