Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize: optimize TccActionInterceptor log print #2683

Merged
merged 1 commit into from
May 13, 2020
Merged

optimize: optimize TccActionInterceptor log print #2683

merged 1 commit into from
May 13, 2020

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented May 12, 2020 •
edited

Ⅰ. Describe what this PR did

优化 TccActionInterceptor 的日志打印。防止调用Tcc接口的toString方法时，打印出NoSuchMethodException异常的WARN日志。

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented May 12, 2020 •
edited

Codecov Report

Merging #2683 into develop will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2683      +/-   ##
=============================================
- Coverage      50.91%   50.90%   -0.02%     
  Complexity      2814     2814              
=============================================
  Files            558      558              
  Lines          17936    17941       +5     
  Branches        2127     2129       +2     
=============================================
  Hits            9132     9132              
- Misses          7934     7939       +5     
  Partials         870      870
Impacted Files Coverage Δ Complexity Δ
...java/io/seata/spring/tcc/TccActionInterceptor.java 11.36% <0.00%> (-1.46%) 2.00 <0.00> (ø)

@zjinlei zjinlei changed the title optimize TccActionInterceptor log print optimize: optimize TccActionInterceptor log print May 12, 2020
@zjinlei zjinlei added this to the 1.3.0 milestone May 12, 2020
@q294881866
Copy link
Contributor

确保测试过了 应该没什么问题

xingfudeshi
xingfudeshi approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi added the first-time contributor first-time contributor label May 13, 2020
zjinlei
zjinlei approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Agree with @q294881866

@zjinlei zjinlei merged commit d146d28 into apache:develop May 13, 2020
@wangliang181230 wangliang181230 deleted the optimize-tcc-log branch June 5, 2020 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@q294881866 q294881866 q294881866 approved these changes

@zjinlei zjinlei zjinlei approved these changes

@xingfudeshi xingfudeshi xingfudeshi approved these changes

Assignees
No one assigned
Labels
first-time contributor first-time contributor
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wangliang181230 @codecov-io @q294881866 @zjinlei @xingfudeshi