bugfix: fix nested GlobalLock unbind prematurely #2698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjinlei
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #2698 +/- ##
=============================================
- Coverage 50.50% 50.49% -0.02%
Complexity 2921 2921
=============================================
Files 572 572
Lines 18610 18613 +3
Branches 2240 2241 +1
=============================================
- Hits 9399 9398 -1
Misses 8285 8285
- Partials 926 930 +4
|
anrror
reviewed
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #2696
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Within an application service:
serviceA(@ GlobalLock + @ Transaction)->serviceB(@ GlobalLock + @ Transaction)
Ⅴ. Special notes for reviews