Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: support jdbc type array, datalink etc. #2708

Merged
merged 8 commits into from
May 26, 2020
Merged

bugfix: support jdbc type array, datalink etc. #2708

merged 8 commits into from
May 26, 2020

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented May 21, 2020

Ⅰ. Describe what this PR did

support jdbc type array, datalink, java_object, ref.

Ⅱ. Does this pull request fix one issue?

fixes: #1139 #2705

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2020

Codecov Report

Merging #2708 into develop will decrease coverage by 0.08%.
The diff coverage is 7.29%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2708      +/-   ##
=============================================
- Coverage      50.98%   50.89%   -0.09%     
- Complexity      2847     2849       +2     
=============================================
  Files            566      567       +1     
  Lines          18067    18173     +106     
  Branches        2103     2166      +63     
=============================================
+ Hits            9211     9250      +39     
- Misses          7944     8029      +85     
+ Partials         912      894      -18     
Impacted Files Coverage Δ Complexity Δ
...io/seata/rm/datasource/sql/serial/SerialArray.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...seata/rm/datasource/undo/AbstractUndoExecutor.java 63.11% <15.00%> (-6.33%) 21.00 <0.00> (ø)
...o/seata/rm/datasource/sql/struct/TableRecords.java 74.71% <20.00%> (-18.15%) 19.00 <0.00> (ø)
...java/io/seata/spring/tcc/TccActionInterceptor.java 11.36% <0.00%> (-0.27%) 2.00% <0.00%> (ø%)
...n/java/io/seata/rm/datasource/ConnectionProxy.java 28.00% <0.00%> (-0.23%) 13.00% <0.00%> (ø%)
...a/io/seata/core/rpc/netty/AbstractRpcRemoting.java 9.28% <0.00%> (-0.16%) 5.00% <0.00%> (ø%)
...in/java/io/seata/server/session/GlobalSession.java 84.16% <0.00%> (-0.10%) 72.00% <0.00%> (+1.00%) ⬇️
...in/java/io/seata/server/session/BranchSession.java 78.10% <0.00%> (+0.07%) 44.00% <0.00%> (ø%)
...a/server/storage/db/store/LogStoreDataBaseDAO.java 71.76% <0.00%> (+0.09%) 34.00% <0.00%> (ø%)
... and 24 more

@jsbxyyx jsbxyyx added the module/rm-datasource rm-datasource module label May 21, 2020
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly added the mode: AT AT transaction mode label May 25, 2020
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 merged commit 4f97349 into apache:develop May 26, 2020
@jsbxyyx jsbxyyx deleted the fix_1139 branch May 26, 2020 08:11
@slievrly slievrly added this to the 1.3.0 milestone Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mode: AT AT transaction mode module/rm-datasource rm-datasource module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataCompareUtils#isFieldEquals equals type
4 participants