Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: has other expression before insert row primary key. #2725

Merged
merged 5 commits into from
Jun 3, 2020
Merged

bugfix: has other expression before insert row primary key. #2725

merged 5 commits into from
Jun 3, 2020

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented May 25, 2020

Ⅰ. Describe what this PR did

fix: has other expression before insert row primary key.

Ⅱ. Does this pull request fix one issue?

fixes #2710

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2020

Codecov Report

Merging #2725 into develop will increase coverage by 0.10%.
The diff coverage is 77.77%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2725      +/-   ##
=============================================
+ Coverage      50.36%   50.46%   +0.10%     
+ Complexity      2889     2886       -3     
=============================================
  Files            572      572              
  Lines          18594    18590       -4     
  Branches        2204     2232      +28     
=============================================
+ Hits            9364     9382      +18     
  Misses          8285     8285              
+ Partials         945      923      -22     
Impacted Files Coverage Δ Complexity Δ
...o/seata/rm/datasource/exec/BaseInsertExecutor.java 66.66% <77.77%> (-2.74%) 35.00 <0.00> (-3.00)
...a/server/storage/db/store/LogStoreDataBaseDAO.java 71.76% <0.00%> (+0.33%) 34.00% <0.00%> (ø%)
...ing/annotation/GlobalTransactionalInterceptor.java 24.60% <0.00%> (+0.60%) 7.00% <0.00%> (ø%)
...buf/convertor/BranchRollbackResponseConvertor.java 100.00% <0.00%> (+2.94%) 3.00% <0.00%> (ø%)
...tobuf/convertor/BranchCommitResponseConvertor.java 100.00% <0.00%> (+3.03%) 3.00% <0.00%> (ø%)
...buf/convertor/GlobalRollbackResponseConvertor.java 100.00% <0.00%> (+3.22%) 3.00% <0.00%> (ø%)
...tobuf/convertor/GlobalCommitResponseConvertor.java 100.00% <0.00%> (+3.33%) 3.00% <0.00%> (ø%)
...tobuf/convertor/GlobalStatusResponseConvertor.java 100.00% <0.00%> (+3.33%) 3.00% <0.00%> (ø%)
...rotobuf/convertor/RegisterRMResponseConvertor.java 82.75% <0.00%> (+3.44%) 3.00% <0.00%> (ø%)
...rotobuf/convertor/RegisterTMResponseConvertor.java 82.75% <0.00%> (+3.44%) 3.00% <0.00%> (ø%)
... and 14 more

@jsbxyyx jsbxyyx added the module/rm-datasource rm-datasource module label May 25, 2020
Copy link
Contributor

@CoffeeLatte007 CoffeeLatte007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
But i think if rank the pk first, maybe logic is simple

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 merged commit 52984e4 into apache:develop Jun 3, 2020
@slievrly slievrly added this to the 1.3.0 milestone Jun 12, 2020
@iiAt-ch iiAt-ch mentioned this pull request Sep 28, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

集成shardingjdbc 批量插入数据,如果sql里面插入now()函数,sea解析异常
5 participants