optimize: optimize get config type from configuration #2730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2730 +/- ##
==========================================
Coverage 51.13% 51.14%
- Complexity 2847 2849 +2
==========================================
Files 566 566
Lines 18075 18077 +2
Branches 2141 2142 +1
==========================================
+ Hits 9243 9245 +2
- Misses 7944 7945 +1
+ Partials 888 887 -1
|
l81893521
reviewed
May 25, 2020
l81893521
reviewed
May 25, 2020
config/seata-config-core/src/main/java/io/seata/config/ConfigurationFactory.java
Outdated
Show resolved
Hide resolved
l81893521
added
first-time contributor
l81893521
reviewed
May 26, 2020
config/seata-config-core/src/main/java/io/seata/config/ConfigurationFactory.java
Show resolved
Hide resolved
slievrly
reviewed
May 26, 2020
| @@ -101,9 +102,14 @@ private static Configuration buildConfiguration() { | |||
| configTypeName = CURRENT_FILE_INSTANCE.getConfig( | |||
| ConfigurationKeys.FILE_ROOT_CONFIG + ConfigurationKeys.FILE_CONFIG_SPLIT_CHAR | |||
| + ConfigurationKeys.FILE_ROOT_TYPE); | |||
|
|
|||
| if (StringUtils.isBlank(configTypeName)) { | |||
| throw new NotSupportYetException("can not get config type: " + configTypeName); | |||
There was a problem hiding this comment.
configTypeName is blank，why not print it out explicitly？
There was a problem hiding this comment.
you are right ,i change the message to "config type can not be null"
slievrly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
fix: get configTypeName exception
Ⅱ. Does this pull request fix one issue?
fixes #2724
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews