Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: change pg driver scope to provide #2734

Merged
merged 2 commits into from
May 28, 2020

Conversation

l81893521
Copy link
Contributor

Ⅰ. Describe what this PR did

The postgre driver would include in seata-all.jar when packaging

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2020

Codecov Report

Merging #2734 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2734   +/-   ##
==========================================
  Coverage      50.89%   50.89%           
- Complexity      2850     2851    +1     
==========================================
  Files            567      567           
  Lines          18172    18172           
  Branches        2166     2165    -1     
==========================================
  Hits            9249     9249           
  Misses          8029     8029           
  Partials         894      894           

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 merged commit ff2b63a into apache:develop May 28, 2020
@l81893521 l81893521 deleted the change_pg_drive_scope branch June 5, 2020 01:37
@slievrly slievrly added this to the 1.3.0 milestone Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants