optimize: optimized the generation rules of thread name factory #2759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2759 +/- ##
=============================================
+ Coverage 50.46% 50.48% +0.01%
- Complexity 2886 2888 +2
=============================================
Files 572 572
Lines 18590 18591 +1
Branches 2232 2232
=============================================
+ Hits 9382 9385 +3
Misses 8285 8285
+ Partials 923 921 -2
|
|
@caohdgege please check style. format code. |
jsbxyyx
reviewed
Jun 4, 2020
common/src/test/java/io/seata/common/thread/NamedThreadFactoryTest.java
Outdated
Show resolved
Hide resolved
xingfudeshi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
optimized the generation rules of thread name factory
Ⅱ. Does this pull request fix one issue?
fixes #2741
Ⅲ. Why don't you add test cases (unit test/integration test)?
has already add
NamedThreadFactoryTest#testThreadNameHasCounterWithPrefixCounterⅣ. Describe how to verify it
test cases pass
can view the thread name using jstack or jconsole
Ⅴ. Special notes for reviews