Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: Optimize the processing logic of XA's RM for unsupported transaction resources. #2765

Merged
merged 3 commits into from
Jun 8, 2020

Conversation

wangliang181230
Copy link
Contributor

Ⅰ. Describe what this PR did

optimize: Optimize the processing logic of XA's RM for unsupported transaction resources.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2020

Codecov Report

Merging #2765 into develop will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2765      +/-   ##
=============================================
- Coverage      50.49%   50.49%   -0.01%     
- Complexity      2920     2923       +3     
=============================================
  Files            572      572              
  Lines          18613    18616       +3     
  Branches        2242     2242              
=============================================
+ Hits            9399     9400       +1     
- Misses          8285     8288       +3     
+ Partials         929      928       -1     
Impacted Files Coverage Δ Complexity Δ
...a/io/seata/rm/datasource/xa/ResourceManagerXA.java 17.85% <0.00%> (-2.15%) 4.00 <0.00> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 55.15% <0.00%> (+0.51%) 29.00% <0.00%> (+1.00%)

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 added the module/rm-datasource rm-datasource module label Jun 8, 2020
@l81893521 l81893521 merged commit fc7f5d7 into apache:develop Jun 8, 2020
@wangliang181230 wangliang181230 deleted the optimize-xa-rm branch June 8, 2020 04:07
@slievrly slievrly added this to the 1.3.0 milestone Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants