-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: TCC two phase method return type supports void. #2770
optimize: TCC two phase method return type supports void. #2770
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2770 +/- ##
=============================================
- Coverage 50.19% 50.18% -0.02%
+ Complexity 2921 2919 -2
=============================================
Files 578 578
Lines 18724 18724
Branches 2253 2253
=============================================
- Hits 9398 9396 -2
Misses 8396 8396
- Partials 930 932 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return
PhaseTwo_CommitFailed_Unretryable
cause the global transaction stop, we can talk this later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
optimize: TCC phase two return type support void and BranchStatus.
此次PR的主要目的:
二阶段执行失败时,可以使用返回类型BranchStatus.PhaseTwo_XxxxxFailed_Unretryable,自主控制是否继续重试二阶段方法。
因为部分情况下,二阶段可以断定一定不会成功,此时可以自主停止重试。
修改:当前PR暂时先只添加void返回类型。是否开放BranchStatus返回类型,再讨论。
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews