optimize: paramsPlaceHolder generate by StringUtils.repeat() #2776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paramsPlaceHolder generate by StringUtils.repeat()
Codecov Report
@@ Coverage Diff @@
## develop #2776 +/- ##
=============================================
- Coverage 50.18% 50.17% -0.01%
+ Complexity 2952 2951 -1
=============================================
Files 588 588
Lines 18938 18932 -6
Branches 2287 2285 -2
=============================================
- Hits 9504 9500 -4
Misses 8489 8489
+ Partials 945 943 -2
|
jsbxyyx
reviewed
Jun 9, 2020
| sb.append(", "); | ||
| } | ||
| } | ||
| String paramsPlaceHolder = org.apache.commons.lang.StringUtils.repeat("?",",",statuses.length); |
There was a problem hiding this comment.
extract repeat method to io.seata.common.util.StringUtils?
There was a problem hiding this comment.
I don't think it's necessary.
There was a problem hiding this comment.
the apache common langs jar often conflicts with other libraries. convenient direct replacement.
slievrly
reviewed
Jun 9, 2020
| xids.stream().forEach(xid -> sj.add("?")); | ||
| String sql = LogStoreSqlsFactory.getLogStoreSqls(dbType).getQueryBranchTransaction(brachTable, sj.toString()); | ||
| List<BranchTransactionDO> rets = new ArrayList<>(length * 3); | ||
| String paramsPlaceHolder = org.apache.commons.lang.StringUtils.repeat("?",",",length); |
There was a problem hiding this comment.
for better readability, please add a space in the separator. ","-> ", "
|
@xianlaioy In addition, you need to format and standardize the pr title. |
jsbxyyx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paramsPlaceHolder generate by StringUtils.repeat()