bugfix: fix can't rollback when set rollback retry count was zero. #2777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2777 +/- ##
=============================================
+ Coverage 50.36% 50.47% +0.11%
Complexity 2919 2919
=============================================
Files 572 572
Lines 18592 18616 +24
Branches 2199 2245 +46
=============================================
+ Hits 9363 9396 +33
- Misses 8277 8288 +11
+ Partials 952 932 -20 |
slievrly
reviewed
Jun 8, 2020
| @@ -120,7 +120,7 @@ public void commit() throws TransactionException { | |||
| return; | |||
| } | |||
| assertXIDNotNull(); | |||
| int retry = COMMIT_RETRY_COUNT; | |||
| int retry = COMMIT_RETRY_COUNT <= 0 ? 1 : COMMIT_RETRY_COUNT;; | |||
There was a problem hiding this comment.
Is it better to use the default value when <=0?
slievrly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
fix could not rollback when set rollback retry count was zero.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews