optimize: CollectionUtils.decodeMap method variables ConcurrentHashMap refact to HashMap #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CollectionUtils.decodeMap 方法内部变量不存在线程安全问题，改成HashMap；
Codecov Report
@@ Coverage Diff @@
## develop #2779 +/- ##
==========================================
Coverage 50.47% 50.47%
+ Complexity 2920 2919 -1
==========================================
Files 572 572
Lines 18616 18616
Branches 2245 2245
==========================================
Hits 9396 9396
Misses 8288 8288
Partials 932 932
|
slievrly
approved these changes
Jun 9, 2020
xianlaioy
changed the title
l81893521
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CollectionUtils.decodeMap 方法内部变量不存在线程安全问题，改成HashMap；
Ⅰ. Describe what this PR did
方法内部变量不存在线程安全问题，改成HashMap；
Ⅱ. Does this pull request fix one issue?
no
Ⅲ. Why don't you add test cases (unit test/integration test)?
no
Ⅳ. Describe how to verify it
run CollectionUtilsTest
Ⅴ. Special notes for reviews