optimize: Modify workerid generation method #2787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
release 0.5.2
Release 0.6.1
release 0.7.1
release 0.8.0
[release] release 1.0.0
release 1.2.0
|
the title prefix optimize: |
funky-eyes
requested changes
Jun 10, 2020
| } | ||
| byte[] ipAddressByteArray = address.getAddress(); | ||
| long workerId = (((ipAddressByteArray[ipAddressByteArray.length - 2] & 0B11) << Byte.SIZE) + (ipAddressByteArray[ipAddressByteArray.length - 1] & 0xFF)); | ||
| Preconditions.checkArgument(workerId >= 0L && workerId < 1024L); |
There was a problem hiding this comment.
if according to the current practice, will the id be greater than 1023? if yes, it is not advisable to simply throw an exception
There was a problem hiding this comment.
No more than 1023, because according to the snowflake algorithm, the maximum 1111111111 is 1023
lj2018110133
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #2787 +/- ##
=============================================
- Coverage 50.22% 50.18% -0.04%
+ Complexity 2954 2952 -2
=============================================
Files 588 588
Lines 18929 18938 +9
Branches 2286 2287 +1
=============================================
- Hits 9507 9504 -3
- Misses 8480 8489 +9
- Partials 942 945 +3
|
funky-eyes
requested changes
Jun 12, 2020
integration/http/src/test/java/io/seata/integration/http/HttpTest.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
Jun 12, 2020
| try { | ||
| address = InetAddress.getLocalHost(); | ||
| } catch (final UnknownHostException e) { | ||
| throw new IllegalStateException("Cannot get LocalHost InetAddress, please check your network!"); |
There was a problem hiding this comment.
the exception information should contain e.
l81893521
reviewed
Jun 19, 2020
| } | ||
| } | ||
| } | ||
| return idWorker; | ||
| } | ||
|
|
||
| public static long initWorkerId() { |
There was a problem hiding this comment.
I think it will always return 8 bytes, is it too big for long?
There was a problem hiding this comment.
Indeed, it will be dealt with next time
…into seata_workerid
|
The same machine, multiple servers, how to solve? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Modify workerid generation method
Ⅱ. Does this pull request fix one issue?
fix #2785
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews