-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: code opt format #2799
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1、do not need to config in springboot env 2、import HttpAutoConfiguration bean for common spring env
if run, must be start a http server by oneself
if run, must be start a http server by oneself
Found a bug in the case of multiple requests, The reason for troubleshooting is that after the execution of the http interface method, the xid in the thread is not released. Since the tomcat uses the thread pool to handle the connection, the xid is reused, and the xid does not exist on the server. Repair method: release the xid after the interface method is finished, like dubbo
2、add all.pom
slievrly
approved these changes
Jun 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## develop #2799 +/- ##
==========================================
Coverage 50.17% 50.18%
- Complexity 2950 2951 +1
==========================================
Files 588 588
Lines 18932 18931 -1
Branches 2285 2284 -1
==========================================
Hits 9500 9500
- Misses 8488 8489 +1
+ Partials 944 942 -2
|
jsbxyyx
approved these changes
Jun 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
The coding format "null ==obj" unified into "obj==null"
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews