Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: code opt format #2799

Merged
merged 88 commits into from
Jun 24, 2020
Merged

optimize: code opt format #2799

merged 88 commits into from
Jun 24, 2020

Conversation

wxbty
Copy link
Member

@wxbty wxbty commented Jun 14, 2020

Ⅰ. Describe what this PR did

The coding format "null ==obj" unified into "obj==null"

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

wangxb and others added 30 commits October 11, 2019 15:06
1、do not need to config in springboot env
2、import HttpAutoConfiguration bean for common spring env
if run, must be start a http server by oneself
if run, must be start a http server by oneself
Found a bug in the case of multiple requests,
The reason for troubleshooting is that after the execution of the http interface method, the xid in the thread is not released. Since the tomcat uses the thread pool to handle the connection, the xid is reused, and the xid does not exist on the server.
Repair method: release the xid after the interface method is finished, like dubbo
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title coding format opt optimize: coding format opt Jun 14, 2020
@slievrly slievrly changed the title optimize: coding format opt optimize: code opt format Jun 14, 2020
@jsbxyyx
Copy link
Member

jsbxyyx commented Jun 15, 2020

image

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2020

Codecov Report

Merging #2799 into develop will increase coverage by 0.00%.
The diff coverage is 16.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2799   +/-   ##
==========================================
  Coverage      50.17%   50.18%           
- Complexity      2950     2951    +1     
==========================================
  Files            588      588           
  Lines          18932    18931    -1     
  Branches        2285     2284    -1     
==========================================
  Hits            9500     9500           
- Misses          8488     8489    +1     
+ Partials         944      942    -2     
Impacted Files Coverage Δ Complexity Δ
...on/src/main/java/io/seata/common/util/NetUtil.java 54.16% <0.00%> (ø) 15.00 <1.00> (ø)
...c/main/java/io/seata/config/FileConfiguration.java 34.84% <0.00%> (ø) 6.00 <1.00> (ø)
...seata/core/exception/TransactionExceptionCode.java 82.75% <0.00%> (ø) 2.00 <0.00> (ø)
...rc/main/java/io/seata/core/rpc/ChannelManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ata/core/rpc/DefaultServerMessageListenerImpl.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...eata/core/rpc/netty/AbstractRpcRemotingServer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../java/io/seata/core/rpc/netty/NettyBaseConfig.java 36.11% <0.00%> (ø) 2.00 <0.00> (ø)
.../io/seata/core/rpc/netty/NettyPoolableFactory.java 9.09% <0.00%> (ø) 2.00 <0.00> (ø)
...main/java/io/seata/core/rpc/netty/RmRpcClient.java 41.66% <0.00%> (ø) 10.00 <1.00> (ø)
...va/io/seata/core/rpc/netty/RpcClientBootstrap.java 42.25% <0.00%> (ø) 6.00 <1.00> (ø)
... and 35 more

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly added the module/common common module label Jun 23, 2020
@jsbxyyx jsbxyyx merged commit 16e07c1 into apache:develop Jun 24, 2020
@slievrly slievrly added this to the 1.3.0 milestone Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/common common module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants