feature: support configuring default global transaction timeoutMillis #2806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2806 +/- ##
=============================================
- Coverage 50.37% 50.37% -0.01%
- Complexity 3090 3091 +1
=============================================
Files 600 600
Lines 19520 19541 +21
Branches 2411 2413 +2
=============================================
+ Hits 9834 9843 +9
- Misses 8699 8707 +8
- Partials 987 991 +4
|
slievrly
reviewed
Jun 17, 2020
spring/src/main/java/io/seata/spring/annotation/GlobalTransactional.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
Jun 17, 2020
spring/src/main/java/io/seata/spring/annotation/GlobalTransactionalInterceptor.java
Outdated
Show resolved
Hide resolved
funky-eyes
requested changes
Jun 19, 2020
spring/src/main/java/io/seata/spring/annotation/GlobalTransactionalInterceptor.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
Jun 22, 2020
spring/src/main/java/io/seata/spring/annotation/GlobalTransactionalInterceptor.java
Outdated
Show resolved
Hide resolved
funky-eyes
requested changes
Jun 22, 2020
spring/src/main/java/io/seata/spring/annotation/GlobalTransactionalInterceptor.java
Outdated
Show resolved
Hide resolved
spring/src/main/java/io/seata/spring/annotation/GlobalTransactionalInterceptor.java
Outdated
Show resolved
Hide resolved
…out-global-config
wangliang181230
changed the title
…global-config # Conflicts: # seata-spring-boot-starter/src/main/java/io/seata/spring/boot/autoconfigure/properties/client/TmProperties.java # seata-spring-boot-starter/src/test/java/io/seata/spring/boot/autoconfigure/PropertiesTest.java # spring/src/main/java/io/seata/spring/annotation/GlobalTransactionalInterceptor.java
slievrly
changed the title
wangliang181230
added
TM
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Oct 22, 2020
ls9527
reviewed
Nov 8, 2020
| @@ -160,8 +186,14 @@ public String name() { | |||
|
|
|||
| @Override | |||
| public TransactionInfo getTransactionInfo() { | |||
| // reset the value of timeout | |||
| int timeout = globalTrxAnno.timeoutMills(); | |||
| if (timeout <= 0 || timeout == DEFAULT_GLOBAL_TRANSACTION_TIMEOUT) { | |||
There was a problem hiding this comment.
对于场景： 全局默认15秒， 指定接口希望60秒。可咋整？
注解应该默认-1，然后这里取消 timeout == DEFAULT_GLOBAL_TRANSACTION_TIMEOUT 的判断才对。
file.properties:
client.tm.defaultGlobalTransactionTimeout=15000
代码如下:
@GlobalTransactional(timeoutMills = 60000, name = "dubbo-gts-seata-example")
public ObjectResponse handleBusiness(BusinessDTO businessDTO) {
}There was a problem hiding this comment.
当初是这么写的，但是大佬说会不好理解，就改成现在这样的。
There was a problem hiding this comment.
你可以设置成61秒就行了
There was a problem hiding this comment.
宝宝心里苦，宝宝说不出。
spring的TransactionDefinition都默认-1了，这里却指定60秒是特殊数字。
但我相信有一天大佬会踩着七彩祥云把这里改掉的
There was a problem hiding this comment.
宝宝心里苦，宝宝说不出。
spring的TransactionDefinition都默认-1了，这里却指定60秒是特殊数字。
但我相信有一天大佬会踩着七彩祥云把这里改掉的
分布式事务不应该想本地事务一样默认无超时时间,因为分布式事务通常发生在调用链当中,如果事务过久不完成,占用的资源会更多,引起的阻塞也会更多
hicf
pushed a commit
to hicf/seata
that referenced
this pull request
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
optimize: Configurable default global transaction timeoutMillis
seata.client.tm.default-global-transaction-timeout=60000Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews