Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: server check auth support SPI #2808

Merged
merged 5 commits into from
Jun 28, 2020
Merged

feature: server check auth support SPI #2808

merged 5 commits into from
Jun 28, 2020

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

feature: server check auth support SPI

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@slievrly slievrly added the module/server server module label Jun 17, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2020

Codecov Report

Merging #2808 into develop will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2808      +/-   ##
=============================================
- Coverage      50.17%   50.16%   -0.01%     
- Complexity      2949     2951       +2     
=============================================
  Files            588      590       +2     
  Lines          18931    18938       +7     
  Branches        2284     2284              
=============================================
+ Hits            9498     9500       +2     
- Misses          8489     8496       +7     
+ Partials         944      942       -2     
Impacted Files Coverage Δ Complexity Δ
...ava/io/seata/core/constants/ConfigurationKeys.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...in/java/io/seata/core/constants/DefaultValues.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...eata/core/rpc/netty/AbstractRpcRemotingServer.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...c/main/java/io/seata/core/rpc/netty/RpcServer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...eata/core/rpc/processor/server/RegRmProcessor.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...eata/core/rpc/processor/server/RegTmProcessor.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...io/seata/server/auth/AbstractCheckAuthHandler.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../io/seata/server/auth/DefaultCheckAuthHandler.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 2 more

slievrly and others added 2 commits June 19, 2020 14:15
Signed-off-by: slievrly <slievrly@163.com>
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 merged commit 9129cda into apache:develop Jun 28, 2020
@slievrly slievrly added this to the 1.3.0 milestone Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/server server module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants