bugfix: fix get PostgreSQL tableMeta error when using sharding JDBC #2812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsbxyyx
reviewed
Jun 19, 2020
| @@ -137,7 +137,7 @@ private TableMeta resultSetMetaToSchema(DatabaseMetaData dbmd, String tableName) | |||
| col.setColumnDef(rsColumns.getString("COLUMN_DEF")); | |||
| col.setSqlDataType(rsColumns.getInt("SQL_DATA_TYPE")); | |||
| col.setSqlDatetimeSub(rsColumns.getInt("SQL_DATETIME_SUB")); | |||
| col.setCharOctetLength(rsColumns.getInt("CHAR_OCTET_LENGTH")); | |||
| col.setCharOctetLength(rsColumns.getString("CHAR_OCTET_LENGTH")); | |||
There was a problem hiding this comment.
与测试用例中的代码冲突了，还是改成getObject吧。
slievrly
added
module/rm-datasource
l81893521
reviewed
Jun 19, 2020
There was a problem hiding this comment.
CI failed. Please check on https://travis-ci.com/github/seata/seata/builds/172154842
Codecov Report
@@ Coverage Diff @@
## develop #2812 +/- ##
==========================================
Coverage 50.24% 50.24%
Complexity 2941 2941
==========================================
Files 587 587
Lines 18869 18869
Branches 2269 2269
==========================================
Hits 9480 9480
Misses 8449 8449
Partials 940 940
|
|
Modify data type compatible with PostgreSQL |
1 similar comment
|
Modify data type compatible with PostgreSQL |
slievrly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Modify data type compatible with PostgreSQL
Ⅱ. Does this pull request fix one issue?
fixes #2807
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews