feature: support send authentication msg #2825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: slievrly <slievrly@163.com>
Codecov Report
@@ Coverage Diff @@
## develop #2825 +/- ##
=============================================
- Coverage 50.45% 50.42% -0.03%
- Complexity 3108 3115 +7
=============================================
Files 593 594 +1
Lines 19571 19613 +42
Branches 2427 2431 +4
=============================================
+ Hits 9874 9890 +16
- Misses 8702 8724 +22
- Partials 995 999 +4
|
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com> # Conflicts: # core/src/main/java/io/seata/core/rpc/netty/TmNettyRemotingClient.java
Codecov Report
@@ Coverage Diff @@
## develop #2825 +/- ##
=============================================
- Coverage 51.09% 51.04% -0.05%
- Complexity 3253 3257 +4
=============================================
Files 608 609 +1
Lines 19979 20021 +42
Branches 2494 2498 +4
=============================================
+ Hits 10208 10220 +12
- Misses 8760 8783 +23
- Partials 1011 1018 +7 |
ph3636
reviewed
Oct 21, 2020
| if (null != extraData) { | ||
| sb.append(extraData); | ||
| } | ||
| if (transactionServiceGroup != null && !transactionServiceGroup.isEmpty()) { |
There was a problem hiding this comment.
Do you need to add EXTRA_DATA_SPLIT_CHAR for this block?
There was a problem hiding this comment.
这块是否需要添加EXTRA_DATA_SPLIT_CHAR来进行区分？
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com> # Conflicts: # spring/src/main/java/io/seata/spring/annotation/GlobalTransactionScanner.java
wangliang181230
approved these changes
Oct 22, 2020
hicf
pushed a commit
to hicf/seata
that referenced
this pull request
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: slievrly slievrly@163.com
Ⅰ. Describe what this PR did
feature: support send authentication msg
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews