Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: downgrade check unlock and asynchronous #2829

Merged
merged 5 commits into from
Jun 28, 2020
Merged

optimize: downgrade check unlock and asynchronous #2829

merged 5 commits into from
Jun 28, 2020

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

optimize: downgrade check unlock and asynchronous

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@slievrly slievrly added the module/spring spring module label Jun 23, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2020

Codecov Report

Merging #2829 into develop will decrease coverage by 0.00%.
The diff coverage is 30.43%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2829      +/-   ##
=============================================
- Coverage      50.15%   50.15%   -0.01%     
- Complexity      2949     2954       +5     
=============================================
  Files            590      591       +1     
  Lines          18938    18950      +12     
  Branches        2284     2285       +1     
=============================================
+ Hits            9498     9504       +6     
- Misses          8496     8503       +7     
+ Partials         944      943       -1     
Impacted Files Coverage Δ Complexity Δ
.../java/io/seata/spring/event/DegradeCheckEvent.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ing/annotation/GlobalTransactionalInterceptor.java 25.19% <22.22%> (+0.78%) 7.00 <0.00> (ø)
...c/main/java/io/seata/core/event/GuavaEventBus.java 70.58% <50.00%> (-29.42%) 6.00 <3.00> (+2.00) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 84.16% <0.00%> (+0.45%) 72.00% <0.00%> (+1.00%)
...o/seata/server/coordinator/DefaultCoordinator.java 55.15% <0.00%> (+0.51%) 30.00% <0.00%> (+2.00%)

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 merged commit 335bee0 into apache:develop Jun 28, 2020
@slievrly slievrly added this to the 1.3.0 milestone Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/spring spring module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants