-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix business exception is lost when compensation succeed in saga mode #2839
bugfix: fix business exception is lost when compensation succeed in saga mode #2839
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2839 +/- ##
=============================================
- Coverage 50.03% 50.02% -0.01%
+ Complexity 2954 2952 -2
=============================================
Files 592 592
Lines 18998 18995 -3
Branches 2290 2290
=============================================
- Hits 9506 9503 -3
+ Misses 8549 8547 -2
- Partials 943 945 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
bug修复:在SAGA事务,以同步方式执行时,正向服务出现异常,补偿方法执行成功后,正向服务的异常未写入,stateMachineInstance中。
现已修复。已可以通过stateMachineInstance.getException()方法获取到该异常了。
此PR从 #2551 中拆分出来的。
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
以同步方式执行SAGA事务,并故意在业务方法中抛出异常,并使冲正补偿执行成功。然后在事务结束后,通过stateMachineInst.getException(),看看是否可以获取到业务方法中抛出的异常信息。
Ⅴ. Special notes for reviews