Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: code opt format about the sqls, and rename brach to branch #2842

Merged
merged 5 commits into from
Jul 2, 2020

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Jun 29, 2020

Ⅰ. Describe what this PR did

  1. 调整sql相关的代码缩进,使其看起来更优雅
  2. brach 重命名为 branch

从PR #2828 拆分出来的。

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2020

Codecov Report

Merging #2842 into develop will increase coverage by 0.02%.
The diff coverage is 92.85%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2842      +/-   ##
=============================================
+ Coverage      50.12%   50.15%   +0.02%     
- Complexity      2971     2976       +5     
=============================================
  Files            597      597              
  Lines          19071    19074       +3     
  Branches        2297     2296       -1     
=============================================
+ Hits            9559     9566       +7     
+ Misses          8558     8557       -1     
+ Partials         954      951       -3     
Impacted Files Coverage Δ Complexity Δ
...ta/core/store/db/sql/log/AbstractLogStoreSqls.java 100.00% <ø> (ø) 10.00 <0.00> (ø)
...a/server/storage/db/store/LogStoreDataBaseDAO.java 71.18% <87.50%> (ø) 31.00 <4.00> (ø)
...seata/core/store/db/sql/log/MysqlLogStoreSqls.java 100.00% <100.00%> (ø) 7.00 <1.00> (ø)
...eata/core/store/db/sql/log/OracleLogStoreSqls.java 100.00% <100.00%> (ø) 7.00 <1.00> (ø)
.../core/store/db/sql/log/PostgresqlLogStoreSqls.java 100.00% <100.00%> (ø) 7.00 <1.00> (ø)
...in/java/io/seata/server/session/GlobalSession.java 84.16% <0.00%> (+0.45%) 72.00% <0.00%> (+1.00%)
...o/seata/server/coordinator/DefaultCoordinator.java 55.15% <0.00%> (+0.51%) 29.00% <0.00%> (+1.00%)
...torage/file/store/FileTransactionStoreManager.java 57.41% <0.00%> (+0.64%) 29.00% <0.00%> (+1.00%)

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit cdbb5f0 into apache:develop Jul 2, 2020
@wangliang181230 wangliang181230 deleted the refactor-store-db-1 branch July 2, 2020 07:19
@slievrly slievrly added this to the 1.3.0 milestone Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants