optimize: Removed Reloadable from the redis/db SessionManager. #2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2843 +/- ##
=============================================
- Coverage 50.57% 50.57% -0.01%
- Complexity 3105 3107 +2
=============================================
Files 599 599
Lines 19510 19528 +18
Branches 2406 2410 +4
=============================================
+ Hits 9868 9877 +9
- Misses 8650 8657 +7
- Partials 992 994 +2
|
wangliang181230
changed the title
wangliang181230
changed the title
l81893521
reviewed
Jul 30, 2020
| } | ||
| break; | ||
| case AsyncCommitting: | ||
| if (storeMode == StoreMode.FILE) { |
There was a problem hiding this comment.
Why only file mode can reload this status of global session?
AsyncCommitting
CommitRetrying
TimeoutRollbackRetrying
Begin
There was a problem hiding this comment.
If say so, this hold method just use for file mode?
…-redis-db-session-manager-2
Codecov Report
@@ Coverage Diff @@
## develop #2843 +/- ##
=============================================
- Coverage 51.04% 51.03% -0.01%
- Complexity 3259 3261 +2
=============================================
Files 609 609
Lines 20027 20045 +18
Branches 2501 2504 +3
=============================================
+ Hits 10222 10230 +8
- Misses 8788 8795 +7
- Partials 1017 1020 +3
|
…-redis-db-session-manager-2
slievrly
reviewed
Oct 22, 2020
wangliang181230
changed the title
wangliang181230
changed the title
wangliang181230
changed the title
…-redis-db-session-manager-2
…r-2' into optimize-redis-db-session-manager-2
wangliang181230
commented
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
从redis和db模式的SessionManager中移除Reloadable接口实现。因为它们并不需要reload。
从PR #2828 拆分出来的。
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews