Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add FstUndoLogParser #2856

Merged
merged 20 commits into from
Oct 26, 2020
Merged

feature: add FstUndoLogParser #2856

merged 20 commits into from
Oct 26, 2020

Conversation

funky-eyes
Copy link
Contributor

Ⅰ. Describe what this PR did

add FstUndoLogParser

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2020

Codecov Report

Merging #2856 into develop will decrease coverage by 0.31%.
The diff coverage is 29.23%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2856      +/-   ##
=============================================
- Coverage      50.56%   50.24%   -0.32%     
- Complexity      3103     3105       +2     
=============================================
  Files            599      601       +2     
  Lines          19515    19536      +21     
  Branches        2404     2373      -31     
=============================================
- Hits            9867     9816      -51     
- Misses          8657     8703      +46     
- Partials         991     1017      +26     
Impacted Files Coverage Δ Complexity Δ
.../java/io/seata/rm/datasource/sql/struct/Field.java 90.90% <ø> (ø) 9.00 <0.00> (ø)
...in/java/io/seata/rm/datasource/sql/struct/Row.java 100.00% <ø> (ø) 10.00 <0.00> (ø)
...o/seata/rm/datasource/sql/struct/TableRecords.java 78.40% <ø> (ø) 21.00 <0.00> (ø)
...ce/undo/parser/UndoLogSerializerClassRegistry.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../datasource/undo/parser/KryoSerializerFactory.java 46.15% <60.00%> (-21.35%) 7.00 <1.00> (+1.00) ⬇️
...ta/rm/datasource/undo/parser/FstUndoLogParser.java 83.33% <83.33%> (ø) 4.00 <4.00> (?)
...ava/io/seata/rm/datasource/undo/BranchUndoLog.java 100.00% <100.00%> (ø) 7.00 <1.00> (ø)
...n/java/io/seata/rm/datasource/undo/SQLUndoLog.java 77.77% <100.00%> (ø) 10.00 <1.00> (ø)
...m/datasource/undo/parser/FstSerializerFactory.java 100.00% <100.00%> (ø) 6.00 <6.00> (?)
...obuf/convertor/BranchRegisterRequestConvertor.java 90.47% <0.00%> (-9.53%) 3.00% <0.00%> (ø%)
... and 28 more

@l81893521 l81893521 added the module/rm-datasource rm-datasource module label Jul 16, 2020
Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implements java.io.Serializable class must define private static final long serialVersionUID field

@funky-eyes
Copy link
Contributor Author

implements java.io.Serializable class must define private static final long serialVersionUID field

ok

@funky-eyes funky-eyes added this to the 1.4.0 milestone Aug 28, 2020
@codecov-io
Copy link

codecov-io commented Oct 12, 2020

Codecov Report

Merging #2856 into develop will increase coverage by 0.05%.
The diff coverage is 93.84%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2856      +/-   ##
=============================================
+ Coverage      51.03%   51.08%   +0.05%     
- Complexity      3258     3275      +17     
=============================================
  Files            609      612       +3     
  Lines          20025    20055      +30     
  Branches        2500     2500              
=============================================
+ Hits           10219    10246      +27     
- Misses          8788     8791       +3     
  Partials        1018     1018              
Impacted Files Coverage Δ Complexity Δ
.../java/io/seata/rm/datasource/sql/struct/Field.java 90.90% <ø> (ø) 9.00 <0.00> (ø)
...in/java/io/seata/rm/datasource/sql/struct/Row.java 100.00% <ø> (ø) 10.00 <0.00> (ø)
...o/seata/rm/datasource/sql/struct/TableRecords.java 75.00% <ø> (ø) 21.00 <0.00> (ø)
...ta/rm/datasource/undo/parser/FstUndoLogParser.java 83.33% <83.33%> (ø) 4.00 <4.00> (?)
...ce/undo/parser/UndoLogSerializerClassRegistry.java 92.85% <92.85%> (ø) 4.00 <4.00> (?)
...ava/io/seata/rm/datasource/undo/BranchUndoLog.java 100.00% <100.00%> (ø) 7.00 <1.00> (ø)
...n/java/io/seata/rm/datasource/undo/SQLUndoLog.java 77.77% <100.00%> (ø) 10.00 <1.00> (ø)
...m/datasource/undo/parser/FstSerializerFactory.java 100.00% <100.00%> (ø) 6.00 <6.00> (?)
.../datasource/undo/parser/KryoSerializerFactory.java 50.94% <100.00%> (-16.56%) 8.00 <2.00> (+2.00) ⬇️
... and 3 more

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

*/
public class FstSerializerFactory {

private static final FstSerializerFactory FACTORY = new FstSerializerFactory();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FACTORY is singleton?

@wangliang181230 wangliang181230 added the type: feature Category issues or prs related to feature request. label Oct 23, 2020
Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsbxyyx jsbxyyx merged commit da0e25b into apache:develop Oct 26, 2020
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module type: feature Category issues or prs related to feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants