-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add FstUndoLogParser #2856
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2856 +/- ##
=============================================
- Coverage 50.56% 50.24% -0.32%
- Complexity 3103 3105 +2
=============================================
Files 599 601 +2
Lines 19515 19536 +21
Branches 2404 2373 -31
=============================================
- Hits 9867 9816 -51
- Misses 8657 8703 +46
- Partials 991 1017 +26
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implements java.io.Serializable class must define private static final long serialVersionUID
field
ok |
Codecov Report
@@ Coverage Diff @@
## develop #2856 +/- ##
=============================================
+ Coverage 51.03% 51.08% +0.05%
- Complexity 3258 3275 +17
=============================================
Files 609 612 +3
Lines 20025 20055 +30
Branches 2500 2500
=============================================
+ Hits 10219 10246 +27
- Misses 8788 8791 +3
Partials 1018 1018
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
*/ | ||
public class FstSerializerFactory { | ||
|
||
private static final FstSerializerFactory FACTORY = new FstSerializerFactory(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The FACTORY is singleton?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
add FstUndoLogParser
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews