Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix can not find com.google.common.eventbus.AsyncEventBus #2868

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

l81893521
Copy link
Contributor

@l81893521 l81893521 commented Jul 8, 2020

Ⅰ. Describe what this PR did

When I install the snapshot version of seata. I found the error of can not find class of

com.google.common.eventbus.AsyncEventBus

Ⅱ. Does this pull request fix one issue?

fix #2869

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@l81893521 l81893521 added this to the 1.3.0 milestone Jul 8, 2020
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2020

Codecov Report

Merging #2868 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2868      +/-   ##
=============================================
+ Coverage      50.15%   50.16%   +0.01%     
- Complexity      3023     3027       +4     
=============================================
  Files            598      598              
  Lines          19311    19311              
  Branches        2347     2346       -1     
=============================================
+ Hits            9686     9688       +2     
  Misses          8664     8664              
+ Partials         961      959       -2     
Impacted Files Coverage Δ Complexity Δ
...in/java/io/seata/server/session/GlobalSession.java 84.16% <0.00%> (+0.45%) 72.00% <0.00%> (+1.00%)
...o/seata/server/coordinator/DefaultCoordinator.java 55.15% <0.00%> (+0.51%) 29.00% <0.00%> (+1.00%)

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 068f991 into apache:develop Jul 8, 2020
@l81893521 l81893521 deleted the fix_can_not_find_class branch July 9, 2020 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not find com.google.common.eventbus.AsyncEventBus in snapshot version
4 participants