Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix get table meta failed when table name like 'schame'.'table'. #2871

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

l81893521
Copy link
Contributor

@l81893521 l81893521 commented Jul 8, 2020

Ⅰ. Describe what this PR did

When get table meta, table meta cache already handle the different kind of table name. so we do not need to transfer it.

Ⅱ. Does this pull request fix one issue?

#2870

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@l81893521 l81893521 added this to the 1.3.0 milestone Jul 8, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #2871 into develop will decrease coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2871      +/-   ##
=============================================
- Coverage      50.15%   50.03%   -0.13%     
  Complexity      3023     3023              
=============================================
  Files            598      598              
  Lines          19311    19309       -2     
  Branches        2347     2318      -29     
=============================================
- Hits            9686     9661      -25     
  Misses          8664     8664              
- Partials         961      984      +23     
Impacted Files Coverage Δ Complexity Δ
...o/seata/rm/datasource/AbstractConnectionProxy.java 11.34% <0.00%> (+0.11%) 5.00 <0.00> (ø)
...obuf/convertor/BranchRegisterRequestConvertor.java 90.47% <0.00%> (-9.53%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalBeginResponseConvertor.java 92.59% <0.00%> (-7.41%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalCommitRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalStatusRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...obuf/convertor/GlobalRollbackRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...protobuf/convertor/RegisterTMRequestConvertor.java 94.73% <0.00%> (-5.27%) 3.00% <0.00%> (ø%)
...protobuf/convertor/RegisterRMRequestConvertor.java 90.47% <0.00%> (-4.77%) 3.00% <0.00%> (ø%)
...otobuf/convertor/BranchReportRequestConvertor.java 95.45% <0.00%> (-4.55%) 3.00% <0.00%> (ø%)
...tobuf/convertor/BranchReportResponseConvertor.java 95.45% <0.00%> (-4.55%) 3.00% <0.00%> (ø%)
... and 14 more

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsbxyyx jsbxyyx merged commit 396e6b3 into apache:develop Jul 8, 2020
@l81893521 l81893521 deleted the fix_get_table_meta_failed branch July 9, 2020 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants