Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: missing escape char in the primary key for the undo sql #2872

Merged
merged 26 commits into from
Jul 8, 2020
Merged

bugfix: missing escape char in the primary key for the undo sql #2872

merged 26 commits into from
Jul 8, 2020

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Jul 8, 2020

Ⅰ. Describe what this PR did

bugfix: missing escape char in the primary key for the undo sql

Ⅱ. Does this pull request fix one issue?

fix #2867

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

jsbxyyx and others added 22 commits May 13, 2020 21:56
…date

# Conflicts:
#	rm-datasource/src/main/java/io/seata/rm/datasource/exec/InsertExecutor.java
…date

# Conflicts:
#	rm-datasource/src/main/java/io/seata/rm/datasource/exec/BaseInsertExecutor.java
#	rm-datasource/src/test/java/io/seata/rm/datasource/exec/BatchInsertExecutorTest.java
#	rm-datasource/src/test/java/io/seata/rm/datasource/exec/MySQLInsertExecutorTest.java
#	rm-datasource/src/test/java/io/seata/rm/datasource/exec/OracleInsertExecutorTest.java
…date

# Conflicts:
#	rm-datasource/src/main/java/io/seata/rm/datasource/exec/BaseInsertExecutor.java
#	rm-datasource/src/test/java/io/seata/rm/datasource/exec/BatchInsertExecutorTest.java
#	rm-datasource/src/test/java/io/seata/rm/datasource/exec/MySQLInsertExecutorTest.java
#	rm-datasource/src/test/java/io/seata/rm/datasource/exec/OracleInsertExecutorTest.java
Signed-off-by: slievrly <slievrly@163.com>
@slievrly slievrly added this to the 1.3.0 milestone Jul 8, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2020

Codecov Report

Merging #2872 into develop will decrease coverage by 0.00%.
The diff coverage is 67.64%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2872      +/-   ##
=============================================
- Coverage      50.14%   50.13%   -0.01%     
- Complexity      3022     3023       +1     
=============================================
  Files            598      598              
  Lines          19316    19304      -12     
  Branches        2350     2350              
=============================================
- Hits            9686     9679       -7     
+ Misses          8668     8664       -4     
+ Partials         962      961       -1     
Impacted Files Coverage Δ Complexity Δ
.../undo/postgresql/PostgresqlUndoInsertExecutor.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../undo/postgresql/PostgresqlUndoUpdateExecutor.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../java/io/seata/rm/datasource/SqlGenerateUtils.java 94.28% <100.00%> (ø) 12.00 <0.00> (ø)
...datasource/undo/mysql/MySQLUndoInsertExecutor.java 88.88% <100.00%> (-1.12%) 7.00 <2.00> (ø)
...datasource/undo/mysql/MySQLUndoUpdateExecutor.java 87.50% <100.00%> (-1.39%) 5.00 <2.00> (ø)
...tasource/undo/oracle/OracleUndoInsertExecutor.java 55.55% <100.00%> (-4.45%) 5.00 <2.00> (ø)
...tasource/undo/oracle/OracleUndoUpdateExecutor.java 87.50% <100.00%> (-1.39%) 5.00 <2.00> (ø)
...in/java/io/seata/server/session/GlobalSession.java 84.16% <0.00%> (+0.45%) 72.00% <0.00%> (+1.00%)

@slievrly
Copy link
Member Author

slievrly commented Jul 8, 2020

oracle:
case sensitive
jdbcTemplate.update("insert into SYSDATE_TBL("id","gmt_create") values(7,sysdate)");
case non-sensitive
jdbcTemplate.update("insert into SYSDATE1_TBL(id,gmt_create,test) values(7,sysdate,?)",new String[]{"test"});

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,format code.

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 merged commit 5b3d446 into apache:develop Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oracle column case cause cannot be rolled back
5 participants