-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: missing escape char in the primary key for the undo sql #2872
Conversation
…date # Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/exec/InsertExecutor.java
…date # Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/exec/BaseInsertExecutor.java # rm-datasource/src/test/java/io/seata/rm/datasource/exec/BatchInsertExecutorTest.java # rm-datasource/src/test/java/io/seata/rm/datasource/exec/MySQLInsertExecutorTest.java # rm-datasource/src/test/java/io/seata/rm/datasource/exec/OracleInsertExecutorTest.java
…date # Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/exec/BaseInsertExecutor.java # rm-datasource/src/test/java/io/seata/rm/datasource/exec/BatchInsertExecutorTest.java # rm-datasource/src/test/java/io/seata/rm/datasource/exec/MySQLInsertExecutorTest.java # rm-datasource/src/test/java/io/seata/rm/datasource/exec/OracleInsertExecutorTest.java
Signed-off-by: slievrly <slievrly@163.com>
Codecov Report
@@ Coverage Diff @@
## develop #2872 +/- ##
=============================================
- Coverage 50.14% 50.13% -0.01%
- Complexity 3022 3023 +1
=============================================
Files 598 598
Lines 19316 19304 -12
Branches 2350 2350
=============================================
- Hits 9686 9679 -7
+ Misses 8668 8664 -4
+ Partials 962 961 -1
|
oracle: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,format code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
bugfix: missing escape char in the primary key for the undo sql
Ⅱ. Does this pull request fix one issue?
fix #2867
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews