bugfix: fix rm client receive response logic. #2887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2887 +/- ##
==========================================
Coverage 50.09% 50.09%
+ Complexity 3019 3017 -2
==========================================
Files 597 597
Lines 19292 19292
Branches 2346 2347 +1
==========================================
Hits 9665 9665
Misses 8660 8660
Partials 967 967 |
|
|
slievrly
reviewed
Jul 14, 2020
slievrly
reviewed
Jul 14, 2020
objcoding
changed the title
This was referenced Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
The previous logic client side did not have onResponse logic. The TransactionMessageHandler interface has an implementation class AbstractRMHandler. The onRequest method is specifically used to handle rm’s commit, rollback, and deleteUndoLog. After putting these logics in the processor, commit, rollback, and deleteUndoLog are all independent. The respective processor, the logic of onResponse is placed in ClientOnResponseProcessor, so the relevant logic of the client response is placed here, unified and centralized processing
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews