Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix misspelling in statelang examples #2890

Merged
merged 2 commits into from
Jul 16, 2020

Conversation

v0y4g3r
Copy link

@v0y4g3r v0y4g3r commented Jul 15, 2020

Ⅰ. Describe what this PR did

Fix spelling issues in saga mode statelang examples. The lowercase 'output' in states will not put any return value into state machine context.

Ⅱ. Does this pull request fix one issue?

NO

Ⅲ. Why don't you add test cases (unit test/integration test)?

N/A

Ⅳ. Describe how to verify it

N/A

Ⅴ. Special notes for reviews

N/A

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2020

Codecov Report

Merging #2890 into develop will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2890      +/-   ##
=============================================
+ Coverage      49.96%   50.09%   +0.12%     
- Complexity      3013     3015       +2     
=============================================
  Files            597      597              
  Lines          19267    19291      +24     
  Branches        2304     2347      +43     
=============================================
+ Hits            9627     9664      +37     
- Misses          8656     8667      +11     
+ Partials         984      960      -24     
Impacted Files Coverage Δ Complexity Δ
...o/seata/server/storage/redis/lock/RedisLocker.java 37.96% <0.00%> (-0.72%) 10.00% <0.00%> (ø%)
...rage/redis/store/RedisTransactionStoreManager.java 36.05% <0.00%> (-0.53%) 20.00% <0.00%> (ø%)
...java/io/seata/spring/tcc/TccActionInterceptor.java 11.36% <0.00%> (-0.27%) 2.00% <0.00%> (ø%)
...n/java/io/seata/rm/datasource/ConnectionProxy.java 28.00% <0.00%> (-0.23%) 13.00% <0.00%> (ø%)
...ta/core/rpc/netty/AbstractNettyRemotingClient.java 19.04% <0.00%> (-0.21%) 8.00% <0.00%> (ø%)
...in/java/io/seata/server/session/GlobalSession.java 84.16% <0.00%> (-0.10%) 72.00% <0.00%> (+1.00%) ⬇️
...ta/core/rpc/netty/AbstractNettyRemotingServer.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...in/java/io/seata/server/session/BranchSession.java 78.10% <0.00%> (+0.07%) 44.00% <0.00%> (ø%)
...a/server/storage/db/store/LogStoreDataBaseDAO.java 71.18% <0.00%> (+0.09%) 31.00% <0.00%> (ø%)
...in/java/io/seata/tm/api/TransactionalTemplate.java 64.34% <0.00%> (+0.31%) 25.00% <0.00%> (ø%)
... and 23 more

@l81893521 l81893521 added first-time contributor first-time contributor module/test test module labels Jul 16, 2020
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.4.0 milestone Jul 16, 2020
Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 changed the title fix misspelling in statelang examples bugfix: fix misspelling in statelang examples Jul 16, 2020
@l81893521 l81893521 merged commit 744b7e3 into apache:develop Jul 16, 2020
l81893521 pushed a commit to l81893521/seata that referenced this pull request Oct 22, 2020
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor module/test test module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants