Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix get table meta failed in postgresql. #2893

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

l81893521
Copy link
Contributor

@l81893521 l81893521 commented Jul 15, 2020

Ⅰ. Describe what this PR did

fix could not get table meta in pg when table name like schema.table

Ⅱ. Does this pull request fix one issue?

#2892

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly added this to the 1.3.0 milestone Jul 15, 2020
Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 changed the title bugfix: fix get table meta failed in pg. bugfix: fix get table meta failed in postgresql. Jul 15, 2020
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2020

Codecov Report

Merging #2893 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2893      +/-   ##
=============================================
- Coverage      50.09%   50.08%   -0.02%     
+ Complexity      3018     3013       -5     
=============================================
  Files            597      597              
  Lines          19292    19291       -1     
  Branches        2347     2347              
=============================================
- Hits            9665     9662       -3     
- Misses          8660     8667       +7     
+ Partials         967      962       -5     
Impacted Files Coverage Δ Complexity Δ
...rce/sql/struct/cache/PostgresqlTableMetaCache.java 75.58% <ø> (-0.29%) 10.00 <0.00> (ø)
...o/postgresql/keyword/PostgresqlKeywordChecker.java 84.00% <0.00%> (-7.00%) 1.00% <0.00%> (-5.00%)
...ource/sql/struct/cache/AbstractTableMetaCache.java 89.28% <0.00%> (+17.85%) 9.00% <0.00%> (+1.00%)

@slievrly slievrly merged commit 131c17f into apache:develop Jul 15, 2020
@l81893521 l81893521 deleted the fix_pg_table_meta_fail branch July 27, 2020 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants