bugfix: fix jedis unlock fail #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2897 +/- ##
=============================================
- Coverage 50.27% 50.27% -0.01%
- Complexity 3047 3049 +2
=============================================
Files 599 599
Lines 19410 19415 +5
Branches 2381 2381
=============================================
+ Hits 9758 9760 +2
- Misses 8674 8679 +5
+ Partials 978 976 -2
|
ph3636
reviewed
Jul 20, 2020
| @@ -144,6 +144,7 @@ public boolean releaseLock(String xid, List<Long> branchIds) { | |||
| if (CollectionUtils.isNotEmpty(keys)) { | |||
| Pipeline pipeline = null; | |||
| Iterator<String> it = keys.iterator(); | |||
| List<String> delKeys = new ArrayList<>(); | |||
| while (it.hasNext()) { | |||
| String key = it.next(); | |||
| LockDO lock = JSON.parseObject(jedis.get(key), LockDO.class); | |||
| @@ -152,13 +153,15 @@ public boolean releaseLock(String xid, List<Long> branchIds) { | |||
| if (pipeline == null) { | |||
| pipeline = jedis.pipelined(); | |||
| } | |||
There was a problem hiding this comment.
It can be deleted and the following with delKeys judgment
slievrly
reviewed
Jul 20, 2020
|
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Oct 22, 2020
hicf
pushed a commit
to hicf/seata
that referenced
this pull request
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
fix jedis unlock fail
Ⅱ. Does this pull request fix one issue?
fix #2898
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews