Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: ColumnUtils add escape with scheme. #2900

Merged
merged 5 commits into from
Jul 22, 2020
Merged

bugfix: ColumnUtils add escape with scheme. #2900

merged 5 commits into from
Jul 22, 2020

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Jul 17, 2020

Ⅰ. Describe what this PR did

pgsql add escape check logic error, ColumnUtils add escape with scheme.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2020

Codecov Report

Merging #2900 into develop will increase coverage by 0.15%.
The diff coverage is 91.11%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2900      +/-   ##
=============================================
+ Coverage      50.09%   50.24%   +0.15%     
- Complexity      3015     3030      +15     
=============================================
  Files            597      597              
  Lines          19291    19328      +37     
  Branches        2347     2353       +6     
=============================================
+ Hits            9663     9711      +48     
+ Misses          8667     8652      -15     
- Partials         961      965       +4     
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/seata/rm/datasource/ColumnUtils.java 86.59% <90.90%> (+6.59%) 27.00 <0.00> (+7.00)
...o/postgresql/keyword/PostgresqlKeywordChecker.java 97.00% <100.00%> (+13.00%) 10.00 <0.00> (+9.00)
...torage/file/store/FileTransactionStoreManager.java 56.77% <0.00%> (-0.65%) 28.00% <0.00%> (-1.00%)
...o/seata/server/coordinator/DefaultCoordinator.java 54.63% <0.00%> (-0.52%) 28.00% <0.00%> (-1.00%)
...in/java/io/seata/server/session/GlobalSession.java 83.71% <0.00%> (-0.46%) 71.00% <0.00%> (-1.00%)
...urce/undo/oracle/keyword/OracleKeywordChecker.java 96.96% <0.00%> (+2.27%) 9.00% <0.00%> (+2.00%)

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly added this to the 1.4.0 milestone Jul 17, 2020
@jsbxyyx jsbxyyx changed the title bugfix: pgsql escape logic error. bugfix: ColumnUtils add escape with scheme. Jul 17, 2020
@l81893521 l81893521 added the module/rm-datasource rm-datasource module label Jul 22, 2020
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 merged commit 665f562 into apache:develop Jul 22, 2020
l81893521 pushed a commit to l81893521/seata that referenced this pull request Oct 22, 2020
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants