Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix getConfig cache value is 'null' #2904

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

funky-eyes
Copy link
Contributor

Ⅰ. Describe what this PR did

bugfix: fix getConfig cache value is 'null'

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added this to the 1.4.0 milestone Jul 17, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2020

Codecov Report

Merging #2904 into develop will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2904      +/-   ##
=============================================
- Coverage      50.09%   50.06%   -0.03%     
+ Complexity      3015     3012       -3     
=============================================
  Files            597      597              
  Lines          19291    19291              
  Branches        2347     2347              
=============================================
- Hits            9664     9659       -5     
- Misses          8667     8668       +1     
- Partials         960      964       +4     
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/seata/config/ConfigurationCache.java 42.10% <0.00%> (-2.64%) 9.00 <0.00> (ø)
...very/registry/zk/ZookeeperRegisterServiceImpl.java 60.93% <0.00%> (-1.57%) 25.00% <0.00%> (-1.00%)
...o/seata/server/coordinator/DefaultCoordinator.java 54.63% <0.00%> (-0.52%) 28.00% <0.00%> (-1.00%)
...in/java/io/seata/server/session/GlobalSession.java 83.71% <0.00%> (-0.46%) 71.00% <0.00%> (-1.00%)

Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 merged commit c4f82e6 into apache:develop Jul 22, 2020
igit-cn referenced this pull request in igit-cn/seata Aug 11, 2020
bugfix: fix getConfig cache value is 'null'(seata#2904)
l81893521 pushed a commit to l81893521/seata that referenced this pull request Oct 22, 2020
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants