Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: Added some configuration items to keep consistent with official documents #2906

Merged
merged 2 commits into from
Jul 22, 2020

Conversation

guang384
Copy link
Contributor

@guang384 guang384 commented Jul 18, 2020

Ⅰ. Describe what this PR did

Add some default configurations when store.mode is 'db'.
These default configurations are added according to the description in the official document.

image

Ⅱ. Does this pull request fix one issue?

fixes #2903

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2020

Codecov Report

Merging #2906 into develop will increase coverage by 0.01%.
The diff coverage is 14.28%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2906      +/-   ##
=============================================
+ Coverage      50.06%   50.08%   +0.01%     
- Complexity      3012     3014       +2     
=============================================
  Files            597      597              
  Lines          19291    19291              
  Branches        2347     2347              
=============================================
+ Hits            9659     9661       +2     
  Misses          8668     8668              
+ Partials         964      962       -2     
Impacted Files Coverage Δ Complexity Δ
...in/java/io/seata/core/constants/DefaultValues.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...eata/core/store/db/AbstractDataSourceProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ta/server/storage/db/lock/DataBaseLockManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rage/db/store/DataBaseTransactionStoreManager.java 71.31% <100.00%> (ø) 23.00 <0.00> (ø)
...in/java/io/seata/server/session/GlobalSession.java 84.16% <0.00%> (+0.45%) 72.00% <0.00%> (+1.00%)
...o/seata/server/coordinator/DefaultCoordinator.java 55.15% <0.00%> (+0.51%) 29.00% <0.00%> (+1.00%)

@funky-eyes funky-eyes added the first-time contributor first-time contributor label Jul 18, 2020
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes
Copy link
Contributor

please modify your title to make it more specific

@guang384 guang384 changed the title fixes #2903 Add the default configurations when store.mode is 'db' optimize: fixes #2903 Add the default configurations when store.mode is 'db' Jul 18, 2020
@guang384 guang384 changed the title optimize: fixes #2903 Add the default configurations when store.mode is 'db' optimize: fixes #2903 Added some configuration items to keep consistent with official documents Jul 18, 2020
@guang384 guang384 changed the title optimize: fixes #2903 Added some configuration items to keep consistent with official documents optimize: Added some configuration items to keep consistent with official documents Jul 18, 2020
Copy link
Contributor Author

@guang384 guang384 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please modify your title to make it more specific

Done

@funky-eyes funky-eyes added this to the 1.4.0 milestone Jul 20, 2020
Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 added module/core core module module/server server module labels Jul 22, 2020
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 merged commit 545b444 into apache:develop Jul 22, 2020
slievrly added a commit that referenced this pull request Jul 22, 2020
funky-eyes pushed a commit that referenced this pull request Jul 22, 2020
l81893521 pushed a commit to l81893521/seata that referenced this pull request Oct 22, 2020
l81893521 pushed a commit to l81893521/seata that referenced this pull request Oct 22, 2020
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor module/core core module module/server server module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

实际参数值与官方文档中默认值不一致
5 participants