-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: Added some configuration items to keep consistent with official documents #2906
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2906 +/- ##
=============================================
+ Coverage 50.06% 50.08% +0.01%
- Complexity 3012 3014 +2
=============================================
Files 597 597
Lines 19291 19291
Branches 2347 2347
=============================================
+ Hits 9659 9661 +2
Misses 8668 8668
+ Partials 964 962 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
please modify your title to make it more specific |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please modify your title to make it more specific
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ith official documents (apache#2906)" (apache#2915)
…ith official documents (apache#2906)" (apache#2915)
Ⅰ. Describe what this PR did
Add some default configurations when store.mode is 'db'.
These default configurations are added according to the description in the official document.
Ⅱ. Does this pull request fix one issue?
fixes #2903
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews