Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:fix error registry type comment #2910

Merged
merged 2 commits into from
Jul 22, 2020

Conversation

sunhuadong0601
Copy link
Contributor

@sunhuadong0601 sunhuadong0601 commented Jul 21, 2020

fix annotation

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

fix comment error
@sunhuadong0601 sunhuadong0601 changed the title Update RegistryType.java bugfix:fix comment error Jul 21, 2020
@sunhuadong0601 sunhuadong0601 changed the title bugfix:fix comment error bugfix:fix annotation Jul 21, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2020

Codecov Report

Merging #2910 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2910   +/-   ##
==========================================
  Coverage      50.25%   50.25%           
  Complexity      3032     3032           
==========================================
  Files            597      597           
  Lines          19328    19328           
  Branches        2353     2353           
==========================================
  Hits            9713     9713           
  Misses          8652     8652           
  Partials         963      963           
Impacted Files Coverage Δ Complexity Δ
...java/io/seata/discovery/registry/RegistryType.java 0.00% <ø> (ø) 0.00 <0.00> (ø)

@funky-eyes funky-eyes added the first-time contributor first-time contributor label Jul 21, 2020
@funky-eyes funky-eyes added this to the 1.4.0 milestone Jul 21, 2020
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 added the module/discovery discovery module label Jul 22, 2020
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 changed the title bugfix:fix annotation bugfix:fix error registry type comment Jul 22, 2020
@l81893521 l81893521 merged commit 7eb6676 into apache:develop Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor module/discovery discovery module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants