Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize some grammatical errors #2920

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Conversation

zdrjson
Copy link
Contributor

@zdrjson zdrjson commented Jul 23, 2020

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2020

Codecov Report

Merging #2920 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2920   +/-   ##
==========================================
  Coverage      50.27%   50.27%           
+ Complexity      3049     3047    -2     
==========================================
  Files            599      599           
  Lines          19410    19410           
  Branches        2380     2381    +1     
==========================================
  Hits            9758     9758           
  Misses          8674     8674           
  Partials         978      978           

@slievrly slievrly changed the title Fix some grammatical errors optimize: optimize some grammatical errors Jul 23, 2020
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly added this to the 1.4.0 milestone Jul 23, 2020
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added the first-time contributor first-time contributor label Jul 23, 2020
@funky-eyes funky-eyes merged commit dca816d into apache:develop Jul 23, 2020
l81893521 pushed a commit to l81893521/seata that referenced this pull request Oct 22, 2020
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants