Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fastjson write undo log not parser. #2926

Merged
merged 3 commits into from
Jul 28, 2020
Merged

bugfix: fastjson write undo log not parser. #2926

merged 3 commits into from
Jul 28, 2020

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Jul 27, 2020

Ⅰ. Describe what this PR did

fastjson write undo log not parser.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2020

Codecov Report

Merging #2926 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2926   +/-   ##
==========================================
  Coverage      50.28%   50.28%           
+ Complexity      3050     3049    -1     
==========================================
  Files            599      599           
  Lines          19410    19410           
  Branches        2381     2381           
==========================================
  Hits            9760     9760           
  Misses          8674     8674           
  Partials         976      976           
Impacted Files Coverage Δ Complexity Δ
.../datasource/undo/parser/FastjsonUndoLogParser.java 90.00% <100.00%> (ø) 5.00 <1.00> (ø)

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsbxyyx jsbxyyx added the module/rm-datasource rm-datasource module label Jul 28, 2020
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit f145cf7 into apache:develop Jul 28, 2020
@jsbxyyx jsbxyyx deleted the fix_fastjson_undolog branch July 28, 2020 03:34
@slievrly slievrly added this to the 1.4.0 milestone Jul 28, 2020
l81893521 pushed a commit to l81893521/seata that referenced this pull request Oct 22, 2020
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants