Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add apollo secret key configuration #2941

Merged
merged 9 commits into from
Aug 6, 2020

Conversation

funky-eyes
Copy link
Contributor

Ⅰ. Describe what this PR did

add apollo secret key configuration

Ⅱ. Does this pull request fix one issue?

fixs #2940

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added the module/config config module label Jul 28, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2020

Codecov Report

Merging #2941 into develop will decrease coverage by 0.00%.
The diff coverage is 25.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2941      +/-   ##
=============================================
- Coverage      50.27%   50.26%   -0.01%     
  Complexity      3060     3060              
=============================================
  Files            600      600              
  Lines          19503    19507       +4     
  Branches        2404     2404              
=============================================
+ Hits            9805     9806       +1     
- Misses          8712     8715       +3     
  Partials         986      986              
Impacted Files Coverage Δ Complexity Δ
...gure/properties/config/ConfigApolloProperties.java 41.17% <25.00%> (-4.98%) 3.00 <0.00> (ø)

@chensp0668
Copy link

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 4887607 into apache:develop Aug 6, 2020
@l81893521 l81893521 added this to the 1.4.0 milestone Sep 21, 2020
l81893521 pushed a commit to l81893521/seata that referenced this pull request Oct 22, 2020
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants