Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: opt additional-spring-configuration-metadata.json #2952

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Jul 31, 2020

Ⅰ. Describe what this PR did

  1. 补充additional-spring-configuration-metadata.json,在springboot项目中,部分配置项可以提示可选值及其说明。
  2. 顺便优化了seata.transport.typeseata.transport.server两个配置,使其兼容大小写以及多格式配置.
  3. 协议枚举中,删除UDT及相关的所有注释,因为暂时还不支持。

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2020

Codecov Report

Merging #2952 into develop will decrease coverage by 0.02%.
The diff coverage is 43.75%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2952      +/-   ##
=============================================
- Coverage      50.25%   50.22%   -0.03%     
- Complexity      3051     3053       +2     
=============================================
  Files            599      599              
  Lines          19430    19443      +13     
  Branches        2384     2386       +2     
=============================================
+ Hits            9764     9766       +2     
- Misses          8690     8696       +6     
- Partials         976      981       +5     
Impacted Files Coverage Δ Complexity Δ
.../java/io/seata/core/serializer/SerializerType.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ure/properties/client/ThreadFactoryProperties.java 45.94% <ø> (ø) 8.00 <0.00> (ø)
...nfigure/properties/client/TransportProperties.java 52.00% <ø> (ø) 7.00 <0.00> (ø)
.../autoconfigure/properties/client/RmProperties.java 44.00% <25.00%> (-3.62%) 5.00 <0.00> (ø)
.../java/io/seata/core/rpc/TransportProtocolType.java 72.72% <40.00%> (-27.28%) 3.00 <1.00> (+1.00) ⬇️
...in/java/io/seata/core/rpc/TransportServerType.java 80.00% <50.00%> (-20.00%) 4.00 <2.00> (+2.00) ⬇️
.../java/io/seata/core/rpc/netty/NettyBaseConfig.java 36.11% <100.00%> (ø) 2.00 <0.00> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 54.63% <0.00%> (-0.52%) 28.00% <0.00%> (-2.00%)
...in/java/io/seata/server/session/GlobalSession.java 83.71% <0.00%> (-0.46%) 71.00% <0.00%> (-1.00%)

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 751ed4a into apache:develop Jul 31, 2020
@funky-eyes funky-eyes added this to the 1.4.0 milestone Jul 31, 2020
@wangliang181230 wangliang181230 deleted the optimize-additional-sb-config-metadata branch July 31, 2020 06:56
l81893521 pushed a commit to l81893521/seata that referenced this pull request Oct 22, 2020
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants