Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize: replace with lambda #2967

Merged
merged 18 commits into from
Aug 4, 2020
Merged

optimize: replace with lambda #2967

merged 18 commits into from
Aug 4, 2020

Conversation

heyaping388
Copy link
Contributor

Ⅰ. Describe what this PR did

optimize: replace with lambda

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2020 •
edited
Loading

Codecov Report

Merging #2967 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2967   +/-   ##
==========================================
  Coverage      50.21%   50.21%           
- Complexity      3053     3055    +2     
==========================================
  Files            599      599           
  Lines          19466    19465    -1     
  Branches        2396     2395    -1     
==========================================
  Hits            9774     9774           
+ Misses          8707     8706    -1     
  Partials         985      985
Impacted Files Coverage Δ Complexity Δ
.../io/seata/core/context/ThreadLocalContextCore.java 33.33% <100.00%> (+4.76%) 1.00 <0.00> (ø)

slievrly
slievrly approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the base branch from master to develop August 4, 2020 03:55
@funky-eyes funky-eyes added the first-time contributor first-time contributor label Aug 4, 2020
funky-eyes
funky-eyes approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added the module/core core module label Aug 4, 2020
@funky-eyes funky-eyes merged commit d68d16d into apache:develop Aug 4, 2020
@l81893521 l81893521 added this to the 1.4.0 milestone Aug 5, 2020
l81893521 pushed a commit to l81893521/seata that referenced this pull request Oct 22, 2020
@heyaping388 @l81893521
optimize: replace with lambda (apache#2967)
5e8a376
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
@heyaping388 @hicf
optimize: replace with lambda (apache#2967)
6986607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slievrly slievrly slievrly approved these changes

@funky-eyes funky-eyes funky-eyes approved these changes

Assignees
No one assigned
Labels
first-time contributor first-time contributor module/core core module
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@heyaping388 @codecov-commenter @slievrly @funky-eyes @l81893521 @zhangthen