Bugfix: UUIDGenerator generates duplicated id #2972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yujianfei1986
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #2972 +/- ##
=============================================
+ Coverage 50.10% 50.21% +0.11%
Complexity 3053 3053
=============================================
Files 599 599
Lines 19438 19463 +25
Branches 2351 2396 +45
=============================================
+ Hits 9739 9774 +35
- Misses 8692 8704 +12
+ Partials 1007 985 -22 |
l81893521
reviewed
Aug 5, 2020
| } else { | ||
| sequence = 0L; | ||
| if (lastTimestamp == timestamp) { | ||
| sequence = (sequence + 1) & sequenceMask; |
There was a problem hiding this comment.
the sequence is different, why cause the duplicated id?
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Oct 22, 2020
hicf
pushed a commit
to hicf/seata
that referenced
this pull request
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
UUIDGenerator类的generateUUID()方法在高并发情况下，会生成重复的id
Ⅱ. Does this pull request fix one issue?
高并发压测发现
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
高并发压测，不会再出现重复的branchid
Ⅴ. Special notes for reviews
UUIDGenerator generate duplicated id